mr: breaking down complex subroutines

Adam Spiers vcs-home at
Sun Feb 19 18:09:45 CET 2012

On Sun, Feb 19, 2012 at 4:46 PM, Joey Hess <joey at> wrote:
> Adam Spiers wrote:
>> I find some parts of the mr script quite hard to follow, and
>> consequently to write patches for.  For example, loadconfig() has 221
>> lines, and is 8 levels of indentation deep at certain points.  Would
>> you accept "extract subroutine" refactoring patches which do not
>> change the functionality in any way, but simply break down some of the
>> longer subroutines into more easily understandable chunks?
> I'm always glad to accept good refactorings.

Great!  I'll see what I can come up with.

More information about the vcs-home mailing list