mr: breaking down complex subroutines

Joey Hess joey at
Sun Feb 19 17:46:49 CET 2012

Adam Spiers wrote:
> I find some parts of the mr script quite hard to follow, and
> consequently to write patches for.  For example, loadconfig() has 221
> lines, and is 8 levels of indentation deep at certain points.  Would
> you accept "extract subroutine" refactoring patches which do not
> change the functionality in any way, but simply break down some of the
> longer subroutines into more easily understandable chunks?

I'm always glad to accept good refactorings.

see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <>

More information about the vcs-home mailing list