mr: breaking down complex subroutines

Adam Spiers vcs-home at
Fri Feb 17 17:02:14 CET 2012

Hi Joey,

I find some parts of the mr script quite hard to follow, and
consequently to write patches for.  For example, loadconfig() has 221
lines, and is 8 levels of indentation deep at certain points.  Would
you accept "extract subroutine" refactoring patches which do not
change the functionality in any way, but simply break down some of the
longer subroutines into more easily understandable chunks?


More information about the vcs-home mailing list