New integration branch
joey at kitenet.net
Sun Dec 4 22:11:49 CET 2011
Adam Spiers wrote:
> OK, as discussed, here's a new 'for-joey' branch based off
> current upstream master:
> All commits are self-contained, and hopefully non-contentious. They
> are mostly minor bugfixes, but there are a few enhancements too - most
> notably lib/stow and lib/download.
loadconfig already uses %loaded to avoid reloading the same
config twice, so this extra check is not necessary, I think.
I picked the bugfix part.
The warning message on missing chain files exposes an unclear
thing in mr; it will try to chain to directories even when their
repository has skip = true, which causes the warning to show
up unexpectedly (ie, here). I think it needs to be changed to
honor skip = true even if chain = true.
I developed a different fix this morning that shows correct
line numbers for both the mrconfig and the position in the
include, it's in my tree.
This makes "mr fetch" do a git fetch, but nothing for
the over DVCSes which can also do things like fetch, and
no documentation of it
Can you give an example of when this is needed?
Already fixed in my tree.
mr is quite typically (I know, not by you) run
inside the repository. Which would leave the user
in an apparently empty directory after mr update if
an mr update deleted and remade the whole repository.
I don't like that; I don't think things in mr should be
deleting repositories in general; mr doesn't even delete
a repo that has deleted = true, it only warns the user about it.
I've held off on these plugins since I think they
depend on 602f26714254f3c65389b7665d15d1d5d0e227a9
This is a slow way to make machine-parsable info available --
the similar mr list takes 8 seconds here, since it has to run
169 shells. That's ok when you're just running mr, but I would
not like to use a command that depended on that information.
If a machine-parseable list of repositories is needed,
I think it'd be better to have a perl function that emits
it in one go.
(Also, the patch references a MR_NAME that is not present in my
I'm not quite sure of the point of this refactoring,
since the factored out download function has a lot
of bootstrap-specific stuff in it?
cherry-picked. Nice feature!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 828 bytes
Desc: Digital signature
More information about the vcs-home